add authentication scenario #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an authentication scenario to the project, providing both a Streamlit authenticator implementation and an alternative login screen using new Streamlit login callbacks.
- Implements authentication using the streamlit_authenticator library in one app
- Adds an alternative authentication screen using Streamlit’s new login/logout callbacks
- Updates tests, scripts, configuration, and documentation to support authentication
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workshop_playwright_python/apps/streamlit_authentication.py | Implements authentication with streamlit_authenticator and handles login errors |
| workshop_playwright_python/apps/authentication.py | Provides an alternative login screen using new Streamlit callbacks |
| tests/test_hatena_bookmark.py | Adds a test marked to be skipped for live-server dependent scenarios |
| tests/flags.py | Introduces a flag to skip tests when necessary |
| scripts/save_context.py | Adds a script to capture and save browser storage state |
| scripts/load_context.py | Adds a script to load the saved authentication context |
| pyproject.toml | Updates project dependencies with authentication-related packages |
| docs/index.md | Updates documentation with guides for authentication |
| compose.yaml | Includes a pgadmin service configuration |
| .streamlit/config.yaml | Provides a sample configuration file for authentication credentials |
Files not reviewed (2)
- .streamlit/secrets.toml.example: Language not supported
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
workshop_playwright_python/apps/authentication.py:7
- Verify that 'st.login' (and similarly 'st.logout' used later) are implemented in your current version of Streamlit, or provide the necessary definitions to ensure they work as expected.
st.button("Log in with Microsoft", on_click=st.login)
Comment on lines
+23
to
+24
|
|
||
| if st.session_state["authentication_status"]: |
There was a problem hiding this comment.
Consider handling a failed login scenario explicitly (e.g. by returning after catching the LoginError) to avoid potential key errors on st.session_state when login fails.
Suggested change
| if st.session_state["authentication_status"]: | |
| st.stop() # Stop further execution if login fails | |
| if st.session_state.get("authentication_status"): # Safeguard to check key existence |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes:
Fixes #3
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Additional Information